feat(rust): allow authenticating into multiple hosts#2278
Merged
Conversation
imobachgs
changed the title
imobachgs
force-pushed
the
multi-host-tokens
branch
from
55e7d76 to
8734185
Compare
mvidner
reviewed
Apr 22, 2025
Contributor
mvidner
left a comment
mvidner
left a comment
There was a problem hiding this comment.
When there is any problem with the file storing the authentication tokens, do we tell the user where it is (agama auth login --help?) or do they have to resort to strace?
Also, my testing use cases involve multiple agamas on the same host but different ports. I hope it continues to work :)
| #[error("Unexpected type on D-Bus '{0}'")] | ||
| ZVariant(#[from] zvariant::Error), | ||
| #[error("Failed to communicate with the HTTP backend '{0}'")] | ||
| #[error(transparent)] |
Merged
imobachgs
added a commit
that referenced
this pull request
Apr 22, 2025
Prepare to release Agama 14: * #1994 * #2041 * #2103 * #2178 * #2189 * #2200 * #2205 * #2209 * #2212 * #2213 * #2214 * #2215 * #2216 * #2217 * #2219 * #2220 * #2224 * #2225 * #2226 * #2227 * #2228 * #2230 * #2231 * #2232 * #2233 * #2235 * #2237 * #2239 * #2241 * #2242 * #2244 * #2245 * #2246 * #2247 * #2248 * #2249 * #2250 * #2251 * #2252 * #2253 * #2254 * #2255 * #2256 * #2257 * #2259 * #2260 * #2262 * #2265 * #2266 * #2268 * #2269 * #2271 * #2272 * #2273 * #2275 * #2276 * #2278 * #2281
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
agama auth show).Solution
Storing one token per host
Instead of storing the token in
$HOME/.agama/token, use a file ($HOME/.local/share/agama) containing all tokens (one per host). For instance:{ "192.168.122.145": "eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJleHAiOjE3NDUzMTg2MTV9.G36w8NQ-ZCAkCQGGwjajRpd8EfkOM8fFLLfGjzTAqP0" }Do not ask for insecure connections
If there is a problem when connecting to the API, just report the error (no matter whether it is an SSL problem or not). The user can use the
--insecureflag to disable certificate checks.Testing